lkml.org 
[lkml]   [2020]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 25/32] usb: early: ehci-dbgp: Remove set but never checked variable 'ret'
On Mon, 06 Jul 2020, Eric W. Biederman wrote:

> Lee Jones <lee.jones@linaro.org> writes:
>
> > 'ret' hasn't been checked since the driver's inception in 2009.
>
> Minor quibble the inception was in 5c05917e7fe3 ("x86: usb debug port
> early console, v4") in July of 2008.

I'm only going back as far as the inception of ehci-dbgp.c.

> Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>

Great, thanks.

> > Fixes the following W=1 kernel build warning(s):
> >
> > drivers/usb/early/ehci-dbgp.c: In function ‘early_dbgp_write’:
> > drivers/usb/early/ehci-dbgp.c:915:13: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
> > 915 | int chunk, ret;
> > | ^~~
> >
> > Cc: Sumit Garg <sumit.garg@linaro.org>
> > Cc: Daniel Thompson <daniel.thompson@linaro.org>
> > Cc: Douglas Anderson <dianders@chromium.org>
> > Cc: Petr Mladek <pmladek@suse.com>
> > Cc: "Eric W. Biederman" <ebiederm@xmission.com>
> > Cc: Yinghai Lu <yhlu.kernel@gmail.com>
> > Cc: Jason Wessel <jason.wessel@windriver.com>
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > ---
> > drivers/usb/early/ehci-dbgp.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

\
 
 \ /
  Last update: 2020-07-06 19:58    [W:0.074 / U:0.728 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site