Messages in this thread | | | From | Namhyung Kim <> | Date | Tue, 7 Jul 2020 00:12:21 +0900 | Subject | Re: [PATCH 1/1] perf report TUI: Remove needless 'dummy' event from menu |
| |
On Mon, Jul 6, 2020 at 8:55 PM Arnaldo Carvalho de Melo <acme@redhat.com> wrote: > > Em Fri, Jul 03, 2020 at 10:44:28PM +0900, Namhyung Kim escreveu: > > > @@ -3613,7 +3630,7 @@ int perf_evlist__tui_browse_hists(struct evlist *evlist, const char *help, > > > int nr_entries = evlist->core.nr_entries; > > > > > > single_entry: > > > - if (nr_entries == 1) { > > > + if (perf_evlist__single_entry(evlist)) { > > > > But I think it cannot cover the event group case below.. > > Right, we can fix that later, I think, my worry at this point was that > the simplest case, which is: > > # perf record > ^C > # perf report > > Would get that annoyance :-)
Right, then I suggest moving the 'single_entry' label to inside of the if statement. With that applied,
Acked-by: Namhyung Kim <namhyung@kernel.org>
Thanks Namhyung
| |