Messages in this thread Patch in this message | | | From | Sergey Organov <> | Subject | [PATCH 3/5] net: fec: initialize clock with 0 rather than current kernel time | Date | Mon, 6 Jul 2020 17:26:14 +0300 |
| |
Initializing with 0 makes it much easier to identify time stamps from otherwise uninitialized clock.
Initialization of PTP clock with current kernel time makes little sense as PTP time scale differs from UTC time scale that kernel time represents. It only leads to confusion when no actual PTP initialization happens, as these time scales differ in a small integer number of seconds (37 at the time of writing.)
Signed-off-by: Sergey Organov <sorganov@gmail.com> --- drivers/net/ethernet/freescale/fec_ptp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/fec_ptp.c b/drivers/net/ethernet/freescale/fec_ptp.c index 4a12086..e455343 100644 --- a/drivers/net/ethernet/freescale/fec_ptp.c +++ b/drivers/net/ethernet/freescale/fec_ptp.c @@ -264,7 +264,7 @@ void fec_ptp_start_cyclecounter(struct net_device *ndev) fep->cc.mult = FEC_CC_MULT; /* reset the ns time counter */ - timecounter_init(&fep->tc, &fep->cc, ktime_to_ns(ktime_get_real())); + timecounter_init(&fep->tc, &fep->cc, 0); spin_unlock_irqrestore(&fep->tmreg_lock, flags); } -- 2.10.0.1.g57b01a3
| |