lkml.org 
[lkml]   [2020]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH -next] smp: Fix unused-but-set-variable warning
Date
Gcc report build warning as follows:

kernel/smp.c:126:15: warning:
variable 'csd_type' set but not used [-Wunused-but-set-variable]
126 | unsigned int csd_type;
| ^~~~~~~~

'csd_type' is only used when CONFIG_64BIT defined, so move them
under '#ifdef'.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
kernel/smp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/smp.c b/kernel/smp.c
index 6ec6c9578225..0130bdcf6d26 100644
--- a/kernel/smp.c
+++ b/kernel/smp.c
@@ -123,10 +123,10 @@ static void csd_lock_record(call_single_data_t *csd)

static __always_inline int csd_lock_wait_getcpu(call_single_data_t *csd)
{
+#ifdef CONFIG_64BIT
unsigned int csd_type;

csd_type = CSD_TYPE(csd);
-#ifdef CONFIG_64BIT
if (csd_type == CSD_TYPE_ASYNC || csd_type == CSD_TYPE_SYNC)
return csd->dst; // Other CSD_TYPE_ values might not have ->dst.
#endif
\
 
 \ /
  Last update: 2020-07-06 15:41    [W:0.026 / U:0.488 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site