lkml.org 
[lkml]   [2020]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 19/32] usb: gadget: function: u_uac1_legacy: Demote obvious misuse of kerneldoc to standard comment blocks
    Date
    No attempt has been made to document any of the demoted functions here.

    Fixes the following W=1 kernel build warning(s):

    drivers/usb/gadget/function/u_uac1_legacy.c:30: warning: Function parameter or member 'i' not described in 'snd_interval_refine_set'
    drivers/usb/gadget/function/u_uac1_legacy.c:30: warning: Function parameter or member 'val' not described in 'snd_interval_refine_set'
    drivers/usb/gadget/function/u_uac1_legacy.c:93: warning: Function parameter or member 'snd' not described in 'playback_default_hw_params'
    drivers/usb/gadget/function/u_uac1_legacy.c:153: warning: Function parameter or member 'card' not described in 'u_audio_playback'
    drivers/usb/gadget/function/u_uac1_legacy.c:153: warning: Function parameter or member 'buf' not described in 'u_audio_playback'
    drivers/usb/gadget/function/u_uac1_legacy.c:153: warning: Function parameter or member 'count' not described in 'u_audio_playback'
    drivers/usb/gadget/function/u_uac1_legacy.c:197: warning: Function parameter or member 'card' not described in 'gaudio_open_snd_dev'
    drivers/usb/gadget/function/u_uac1_legacy.c:257: warning: Function parameter or member 'gau' not described in 'gaudio_close_snd_dev'
    drivers/usb/gadget/function/u_uac1_legacy.c:286: warning: Function parameter or member 'card' not described in 'gaudio_setup'
    drivers/usb/gadget/function/u_uac1_legacy.c:303: warning: Function parameter or member 'the_card' not described in 'gaudio_cleanup'

    Cc: Felipe Balbi <balbi@kernel.org>
    Cc: Bryan Wu <cooloney@kernel.org>
    Signed-off-by: Lee Jones <lee.jones@linaro.org>
    ---
    drivers/usb/gadget/function/u_uac1_legacy.c | 14 +++++++-------
    1 file changed, 7 insertions(+), 7 deletions(-)

    diff --git a/drivers/usb/gadget/function/u_uac1_legacy.c b/drivers/usb/gadget/function/u_uac1_legacy.c
    index 5393e5c37a4ba..60ae8b2d3f6a2 100644
    --- a/drivers/usb/gadget/function/u_uac1_legacy.c
    +++ b/drivers/usb/gadget/function/u_uac1_legacy.c
    @@ -23,7 +23,7 @@

    /*-------------------------------------------------------------------------*/

    -/**
    +/*
    * Some ALSA internal helper functions
    */
    static int snd_interval_refine_set(struct snd_interval *i, unsigned int val)
    @@ -86,7 +86,7 @@ static int _snd_pcm_hw_param_set(struct snd_pcm_hw_params *params,
    }
    /*-------------------------------------------------------------------------*/

    -/**
    +/*
    * Set default hardware params
    */
    static int playback_default_hw_params(struct gaudio_snd_dev *snd)
    @@ -146,7 +146,7 @@ static int playback_default_hw_params(struct gaudio_snd_dev *snd)
    return 0;
    }

    -/**
    +/*
    * Playback audio buffer data by ALSA PCM device
    */
    size_t u_audio_playback(struct gaudio *card, void *buf, size_t count)
    @@ -189,7 +189,7 @@ int u_audio_get_playback_rate(struct gaudio *card)
    return card->playback.rate;
    }

    -/**
    +/*
    * Open ALSA PCM and control device files
    * Initial the PCM or control device
    */
    @@ -250,7 +250,7 @@ static int gaudio_open_snd_dev(struct gaudio *card)
    return 0;
    }

    -/**
    +/*
    * Close ALSA PCM and control device files
    */
    static int gaudio_close_snd_dev(struct gaudio *gau)
    @@ -275,7 +275,7 @@ static int gaudio_close_snd_dev(struct gaudio *gau)
    return 0;
    }

    -/**
    +/*
    * gaudio_setup - setup ALSA interface and preparing for USB transfer
    *
    * This sets up PCM, mixer or MIDI ALSA devices fore USB gadget using.
    @@ -294,7 +294,7 @@ int gaudio_setup(struct gaudio *card)

    }

    -/**
    +/*
    * gaudio_cleanup - remove ALSA device interface
    *
    * This is called to free all resources allocated by @gaudio_setup().
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-07-06 15:36    [W:3.785 / U:0.444 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site