Messages in this thread Patch in this message | | | From | Arnd Bergmann <> | Date | Mon, 6 Jul 2020 15:04:03 +0200 | Subject | Re: file.c:undefined reference to `.dump_emit' |
| |
On Mon, Jul 6, 2020 at 12:17 PM kernel test robot <lkp@intel.com> wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > head: dcb7fd82c75ee2d6e6f9d8cc71c52519ed52e258 > commit: 5456ffdee666c66e27ccc1006f9afe83ad55559f powerpc/spufs: simplify spufs core dumping > date: 9 weeks ago > config: powerpc64-randconfig-c003-20200706 (attached as .config) > compiler: powerpc64-linux-gcc (GCC) 9.3.0 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp@intel.com> > > All errors (new ones prefixed by >>): > > powerpc64-linux-ld: arch/powerpc/platforms/pseries/lpar.o:(.toc+0x0): undefined reference to `mmu_pid_bits' > powerpc64-linux-ld: arch/powerpc/platforms/cell/spufs/file.o: in function `.spufs_proxydma_info_dump': > >> file.c:(.text+0x4c68): undefined reference to `.dump_emit' > powerpc64-linux-ld: arch/powerpc/platforms/cell/spufs/file.o: in function `.spufs_dma_info_dump': > file.c:(.text+0x4d70): undefined reference to `.dump_emit' > powerpc64-linux-ld: arch/powerpc/platforms/cell/spufs/file.o: in function `.spufs_wbox_info_dump': > file.c:(.text+0x4df4): undefined reference to `.dump_emit' > powerpc64-linux-ld: arch/powerpc/platforms/cell/spufs/file.o: in function `.spufs_ibox_info_dump': > file.c:(.text+0x4e50): undefined reference to `.dump_emit' > powerpc64-linux-ld: arch/powerpc/platforms/cell/spufs/file.o: in function `.spufs_mbox_info_dump': > file.c:(.text+0x4eb0): undefined reference to `.dump_emit' > powerpc64-linux-ld: arch/powerpc/platforms/cell/spufs/file.o:file.c:(.text+0x4f10): more undefined references to `.dump_emit' follow
I'm sure there is a way to fix this properly with added complexity, either making dump_emit() an empty inline function when CONFIG_COREDUMP is disabled, or adding a lot of #ifdef checks in spufs itself.
In the interest of keeping things simple, I'd suggest doing this one instead:
--- a/arch/powerpc/platforms/cell/Kconfig +++ b/arch/powerpc/platforms/cell/Kconfig @@ -44,6 +44,7 @@ config SPU_FS tristate "SPU file system" default m depends on PPC_CELL + depends on COREDUMP select SPU_BASE help The SPU file system is used to access Synergistic Processing I'll send a proper patch if there are no objections.
Arnd
| |