lkml.org 
[lkml]   [2020]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [RFC PATCH v2 11/18] media: tegra-video: Add support for external sensor capture
    From
    Date
    On 17/06/2020 03:41, Sowjanya Komatineni wrote:
    > This patch adds support to capture from the external sensor
    > based on device graph in the device tree.
    >
    > Driver walks through the device graph to create media links
    > between the entities and registers and unregisters video devices
    > when the corresponding sub-devices are bound and unbound.
    >
    > Channel formats are enumerated based on available formats from
    > the sensor and the corresponding matched formats from the Tegra
    > supported video formats list.
    >
    > Each Tegra CSI instance can be configured as 4-lane or 2-lane
    > based on supported lane configuration from the sensor through
    > the device tree.
    >
    > Currently this driver supports V4L2 video node centric only.
    >
    > Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
    > ---
    > drivers/staging/media/tegra-video/Kconfig | 1 +
    > drivers/staging/media/tegra-video/csi.c | 128 +++++-
    > drivers/staging/media/tegra-video/csi.h | 1 +
    > drivers/staging/media/tegra-video/tegra210.c | 2 +-
    > drivers/staging/media/tegra-video/vi.c | 623 +++++++++++++++++++++++++--
    > drivers/staging/media/tegra-video/vi.h | 23 +-
    > 6 files changed, 726 insertions(+), 52 deletions(-)
    >

    <snip>

    > +static int tegra_csi_channels_alloc(struct tegra_csi *csi)
    > +{
    > + struct device_node *node = csi->dev->of_node;
    > + struct v4l2_fwnode_endpoint v4l2_ep = { .bus_type = 0 };

    A bus_type value of 0 is deprecated, this should be set to a valid
    bus_type (probably V4L2_MBUS_CSI2_DPHY).

    Regards,

    Hans

    \
     
     \ /
      Last update: 2020-07-06 13:58    [W:4.137 / U:0.216 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site