lkml.org 
[lkml]   [2020]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] watchdog: bcm_kona_wdt: Use correct return value for bcm_kona_wdt_probe()
From
Date
On 05/25/2020 09:47 PM, Guenter Roeck wrote:
> On 5/25/20 12:31 AM, Tiezhu Yang wrote:
>> When call function devm_platform_ioremap_resource(), we should use IS_ERR()
>> to check the return value and return PTR_ERR() if failed.
>>
>> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>

Hi,

Could you please apply this patch?

Thanks,
Tiezhu

>
>> ---
>> drivers/watchdog/bcm_kona_wdt.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/watchdog/bcm_kona_wdt.c b/drivers/watchdog/bcm_kona_wdt.c
>> index eb850a8..8237c4e 100644
>> --- a/drivers/watchdog/bcm_kona_wdt.c
>> +++ b/drivers/watchdog/bcm_kona_wdt.c
>> @@ -279,7 +279,7 @@ static int bcm_kona_wdt_probe(struct platform_device *pdev)
>>
>> wdt->base = devm_platform_ioremap_resource(pdev, 0);
>> if (IS_ERR(wdt->base))
>> - return -ENODEV;
>> + return PTR_ERR(wdt->base);
>>
>> wdt->resolution = SECWDOG_DEFAULT_RESOLUTION;
>> ret = bcm_kona_wdt_set_resolution_reg(wdt);
>>

\
 
 \ /
  Last update: 2020-07-06 11:02    [W:0.052 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site