lkml.org 
[lkml]   [2020]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH v2 09/12] libnvdimm: Convert to DEVICE_ATTR_ADMIN_RO()
    From
    Date
    Move libnvdimm sysfs attributes that currently use an open coded
    DEVICE_ATTR() to hide sensitive root-only information (physical memory
    layout) to the new DEVICE_ATTR_ADMIN_RO() helper.

    Cc: Vishal Verma <vishal.l.verma@intel.com>
    Cc: Dave Jiang <dave.jiang@intel.com>
    Cc: Ira Weiny <ira.weiny@intel.com>
    Signed-off-by: Dan Williams <dan.j.williams@intel.com>
    ---
    drivers/nvdimm/namespace_devs.c | 2 +-
    drivers/nvdimm/pfn_devs.c | 2 +-
    drivers/nvdimm/region_devs.c | 2 +-
    3 files changed, 3 insertions(+), 3 deletions(-)

    diff --git a/drivers/nvdimm/namespace_devs.c b/drivers/nvdimm/namespace_devs.c
    index ae155e860fdc..6da67f4d641a 100644
    --- a/drivers/nvdimm/namespace_devs.c
    +++ b/drivers/nvdimm/namespace_devs.c
    @@ -1309,7 +1309,7 @@ static ssize_t resource_show(struct device *dev,
    return -ENXIO;
    return sprintf(buf, "%#llx\n", (unsigned long long) res->start);
    }
    -static DEVICE_ATTR(resource, 0400, resource_show, NULL);
    +static DEVICE_ATTR_ADMIN_RO(resource);

    static const unsigned long blk_lbasize_supported[] = { 512, 520, 528,
    4096, 4104, 4160, 4224, 0 };
    diff --git a/drivers/nvdimm/pfn_devs.c b/drivers/nvdimm/pfn_devs.c
    index 34db557dbad1..3e11ef8d3f5b 100644
    --- a/drivers/nvdimm/pfn_devs.c
    +++ b/drivers/nvdimm/pfn_devs.c
    @@ -218,7 +218,7 @@ static ssize_t resource_show(struct device *dev,

    return rc;
    }
    -static DEVICE_ATTR(resource, 0400, resource_show, NULL);
    +static DEVICE_ATTR_ADMIN_RO(resource);

    static ssize_t size_show(struct device *dev,
    struct device_attribute *attr, char *buf)
    diff --git a/drivers/nvdimm/region_devs.c b/drivers/nvdimm/region_devs.c
    index 4502f9c4708d..20ff30c2ab93 100644
    --- a/drivers/nvdimm/region_devs.c
    +++ b/drivers/nvdimm/region_devs.c
    @@ -605,7 +605,7 @@ static ssize_t resource_show(struct device *dev,

    return sprintf(buf, "%#llx\n", nd_region->ndr_start);
    }
    -static DEVICE_ATTR(resource, 0400, resource_show, NULL);
    +static DEVICE_ATTR_ADMIN_RO(resource);

    static ssize_t persistence_domain_show(struct device *dev,
    struct device_attribute *attr, char *buf)
    \
     
     \ /
      Last update: 2020-07-07 04:39    [W:3.612 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site