Messages in this thread | | | From | Andy Shevchenko <> | Date | Sat, 4 Jul 2020 14:23:09 +0300 | Subject | Re: [PATCH v6] gpio: pca953x: Add Maxim MAX7313 PWM support |
| |
On Fri, Jul 3, 2020 at 5:53 PM Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > On Sun, May 03, 2020 at 12:54:53PM +0200, Miquel Raynal wrote:
...
> > + ret = regmap_read(pca_chip->regmap, reg, &val); > > + mutex_unlock(&pca_chip->i2c_lock); > > + if (ret < 0) { > > + dev_err(dev, "Cannot retrieve PWM intensity (%d)\n", ret); > > Please use %pe for error codes.
%pe is mainly for error pointers, with plain integers it will look awkward a bit.
> > + return 0; > > + }
-- With Best Regards, Andy Shevchenko
| |