lkml.org 
[lkml]   [2020]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/2] genirq: Kill preflow handlers
Hi Valentin,

On 2020-07-03 16:56, Valentin Schneider wrote:
> Hi,
>
> while strolling around the different flow handlers, I tried to make
> sense of
> what preflow_handler() was about. Turns out no one uses those anymore,
> but the
> genirq support has remained in place.

If we needed to reintroduce some form of preflow handler, we'd try and
do it using hierarchical irqchips, if at all possible.

>
> Unless we can see another user of those in the near future, this seems
> like as
> good a time as any for a little housecleaning.
>
> - Patch 1 simply deselects the (unexploited) preflow Kconfig for
> sparc64
> - Patch 2 is the actual cleanup
>
> Cheers,
> Valentin
>
> Valentin Schneider (2):
> sparc64: Deselect IRQ_PREFLOW_FASTEOI
> genirq: Remove preflow handler support
>
> arch/sparc/Kconfig | 1 -
> include/linux/irqdesc.h | 15 ---------------
> include/linux/irqhandler.h | 1 -
> kernel/irq/Kconfig | 4 ----
> kernel/irq/chip.c | 13 -------------
> 5 files changed, 34 deletions(-)

For the whole series, and assuming that there is no regression
(can't imagine any for unused code):

Reviewed-by: Marc Zyngier <maz@kernel.org>

Thanks,

M.
--
Jazz is not dead. It just smells funny...

\
 
 \ /
  Last update: 2020-07-04 11:50    [W:0.083 / U:0.388 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site