| Date | Sat, 4 Jul 2020 20:14:17 +0100 | From | Matthew Wilcox <> | Subject | Re: [PATCH 1/3] readfile: implement readfile syscall |
| |
On Sat, Jul 04, 2020 at 04:02:47PM +0200, Greg Kroah-Hartman wrote: > + /* only accept a small subset of O_ flags that make sense */ > + if ((flags & (O_NOFOLLOW | O_NOATIME)) != flags) > + return -EINVAL; > + > + /* add some needed flags to be able to open the file properly */ > + flags |= O_RDONLY | O_LARGEFILE;
Should we also add O_NOCTTY to prevent any problems if this is called on a tty?
|