Messages in this thread | | | Date | Fri, 31 Jul 2020 16:38:42 +0200 (CEST) | From | Julia Lawall <> | Subject | Re: [v4] coccinelle: api: add kvfree script |
| |
On Fri, 31 Jul 2020, Markus Elfring wrote:
> >>>>> +msg = "WARNING: kmalloc is used to allocate this memory at line %s" % (k[0].line) > >>>>> +coccilib.org.print_todo(p[0], msg) > >>>> > >>>> * I find the diagnostic text insufficient. > >>> > >>> I also find the message not very informative. > >> > >> Is it interesting how quick such views can change? > > > > Yes. If one looks at something in context, one and understand it better > > than the extract that you provided. > > Should the provided information (and its intention) be understandable from > the diagnostic message alone already?
It is understandable from the message and from the positions that are indicated. That's good enough.
julia
| |