lkml.org 
[lkml]   [2020]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 9/9] objtool: Abstract unwind hint reading
On Fri, Jul 31, 2020 at 08:00:58AM +0100, Julien Thierry wrote:
> > > + cfa->offset = hint->sp_offset;
> > > + insn->cfi.hint_type = hint->type;
> > > + insn->cfi.end = hint->end;
> > > +
> > > + insn->cfi.sp_only = hint->type == ORC_TYPE_REGS || hint->type == ORC_TYPE_REGS_IRET;
> >
> > What does "sp" mean here in sp_only?
> >
>
> Stack pointer, like in CFI_SP. When objtool encounters one of these hints,
> it starts to only track the stack frame with the stack pointer (no BP, no
> drap register, no move to temporary registers). Just trying to make some
> sense of this corner case.

I think that's not quite right, because ORC_TYPE_CALL could also be
"sp_only" in some cases, by that definition.

The call to update_cfi_state_regs() is really regs-specific, not
sp-specific.

--
Josh

\
 
 \ /
  Last update: 2020-07-31 16:05    [W:0.484 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site