Messages in this thread Patch in this message | | | From | Denis Efremov <> | Subject | Re: [PATCH v4] coccinelle: api: add kvfree script | Date | Fri, 31 Jul 2020 11:31:52 +0300 |
| |
> With the current patch mode, I got some changes in a recent linux-next. > Have you sent patches for these issues?
For mellanox, I've sent these patches: https://lkml.org/lkml/2020/6/5/901 https://lkml.org/lkml/2020/6/1/713 They were accepted.
I see two new places in mellanox driver in linux-next. It looks like this is new code that is not yet merged to the linux master branch.
diff -u -p a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_fs.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_fs.c --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_fs.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_fs.c @@ -228,8 +228,8 @@ static int rx_fs_create(struct mlx5e_pri fs_prot->miss_rule = miss_rule;
out: - kfree(flow_group_in); - kfree(spec); + kvfree(flow_group_in); + kvfree(spec); return err; }
diff -u -p a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c @@ -191,7 +191,7 @@ static int accel_fs_tcp_create_groups(st ft->g = kcalloc(MLX5E_ACCEL_FS_TCP_NUM_GROUPS, sizeof(*ft->g), GFP_KERNEL); in = kvzalloc(inlen, GFP_KERNEL); if (!in || !ft->g) { - kvfree(ft->g); + kfree(ft->g); kvfree(in); return -ENOMEM; }
I will send the fixes when the code will be merged to the linux master branch. Maybe it will be fixed already in net-next at that time.
> > Do the checks for the opportunities for kvmalloc really belong in this > rule? That issue is not mentioned in the commit log or the description of > the semantic patch.
I added this at the last moment. It was easy enough to add it based on existing patterns. I will add description for this warnings. Or do you want me to single out this warning to a separate rule?
Regards, Denis
| |