Messages in this thread | | | Date | Thu, 30 Jul 2020 19:16:39 +0100 | From | Mark Brown <> | Subject | Re: [PATCH v9 0/4] driver core: add probe error check helper |
| |
On Thu, Jul 30, 2020 at 10:46:31AM -0700, Dmitry Torokhov wrote: > On Thu, Jul 30, 2020 at 9:49 AM Mark Brown <broonie@kernel.org> wrote:
> > The error messages are frequently in the caller rather than the > > frameworks, it's often helpful for the comprehensibility of the error > > messages especially in cases where things may be legitimately absent.
> Not for deferral. All you need to know in this case is:
> "device A is attempting to request resource B which is not ready yet"
> There is nothing to handle on the caller part except to float the error up.
You can sometimes do a better job of explaining what the resource you were looking for was, and of course you still need diagnostics in the non-deferral case. Whatever happens we'll need a lot of per-driver churn, either removing existing diagnostics that get factored into cores or updating to use this new API. [unhandled content-type:application/pgp-signature] | |