lkml.org 
[lkml]   [2020]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 07/10] gpio: dwapb: Discard ACPI GPIO-chip IRQs request
    Date
    Since GPIOlib-based IRQ-chip interface is now utilized there is no need
    in calling the methods acpi_gpiochip_{request,free}_interrupts() here.
    They will be called from gpiochip_add_irqchip()/gpiochip_irqchip_remove()
    anyway.

    Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
    Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

    ---

    Changelog v2:
    - This is a new patch detached from commit
    "gpio: dwapb: Convert driver to using the GPIO-lib-based IRQ-chip".
    ---
    drivers/gpio/gpio-dwapb.c | 4 ----
    1 file changed, 4 deletions(-)

    diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c
    index b6affe7161b0..707e9087ca59 100644
    --- a/drivers/gpio/gpio-dwapb.c
    +++ b/drivers/gpio/gpio-dwapb.c
    @@ -526,9 +526,6 @@ static int dwapb_gpio_add_port(struct dwapb_gpio *gpio,
    return err;
    }

    - /* Add GPIO-signaled ACPI event support */
    - acpi_gpiochip_request_interrupts(&port->gc);
    -
    port->is_registered = true;

    return 0;
    @@ -544,7 +541,6 @@ static void dwapb_gpio_unregister(struct dwapb_gpio *gpio)
    if (!port->is_registered)
    continue;

    - acpi_gpiochip_free_interrupts(&port->gc);
    gpiochip_remove(&port->gc);
    }
    }
    --
    2.27.0
    \
     
     \ /
      Last update: 2020-07-30 17:28    [W:3.945 / U:0.264 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site