Messages in this thread | | | Subject | Re: [PATCH] exfat: retain 'VolumeFlags' properly | From | Tetsuhiro Kohada <> | Date | Thu, 30 Jul 2020 15:24:14 +0900 |
| |
Ping..
On 2020/07/15 19:06, Tetsuhiro Kohada wrote: >> It looks complicated. It would be better to simply set/clear VOLUME DIRTY bit. > > I think exfat_set_vol_flags() gets a little complicated, > because it needs the followings (with bit operation) > a) Set/Clear VOLUME_DIRTY. > b) Set MEDIA_FAILUR.
How about splitting these into separate functions as below?
exfat_set_volume_dirty() exfat_set_vol_flags(sb, sbi->vol_flag | VOLUME_DIRTY);
exfat_clear_volume_dirty() exfat_set_vol_flags(sb, sbi->vol_flag & ~VOLUME_DIRTY);
exfat_set_media_failure() exfat_set_vol_flags(sb, sbi->vol_flag | MEDIA_FAILURE);
The implementation is essentially the same for exfat_set_vol_flags(), but I think the intention of the operation will be easier to understand.
BR --- Tetsuhiro Kohada <kohada.t2@gmail.com>
| |