Messages in this thread | | | Subject | Re: [v3,1/5] dt-binding: mediatek: watchdog: fix the description of compatible | From | Matthias Brugger <> | Date | Thu, 30 Jul 2020 13:11:34 +0200 |
| |
On 30/07/2020 12:21, Crystal Guo wrote: > Besides watchdog, mt2712 and nt8183 also provide sub-system software > reset features. But mt6589 not support this feature > > Signed-off-by: Crystal Guo <crystal.guo@mediatek.com>
My proposal for the commit message:
"The watchdog driver for MT2712 and MT8183 relies on DT data, so the fallback compatible MT6589 won't work."
With that or anything like that:
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> --- > Documentation/devicetree/bindings/watchdog/mtk-wdt.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt > index 4dd36bd..45eedc2 100644 > --- a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt > +++ b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt > @@ -4,13 +4,13 @@ Required properties: > > - compatible should contain: > "mediatek,mt2701-wdt", "mediatek,mt6589-wdt": for MT2701 > - "mediatek,mt2712-wdt", "mediatek,mt6589-wdt": for MT2712 > + "mediatek,mt2712-wdt": for MT2712 > "mediatek,mt6589-wdt": for MT6589 > "mediatek,mt6797-wdt", "mediatek,mt6589-wdt": for MT6797 > "mediatek,mt7622-wdt", "mediatek,mt6589-wdt": for MT7622 > "mediatek,mt7623-wdt", "mediatek,mt6589-wdt": for MT7623 > "mediatek,mt7629-wdt", "mediatek,mt6589-wdt": for MT7629 > - "mediatek,mt8183-wdt", "mediatek,mt6589-wdt": for MT8183 > + "mediatek,mt8183-wdt": for MT8183 > "mediatek,mt8516-wdt", "mediatek,mt6589-wdt": for MT8516 > > - reg : Specifies base physical address and size of the registers. >
| |