Messages in this thread Patch in this message | | | From | Deepak Kumar Singh <> | Subject | [PATCH V1 5/6] rpmsg: glink: Remove channel decouple from rpdev release | Date | Thu, 30 Jul 2020 10:48:15 +0530 |
| |
From: Chris Lew <clew@codeaurora.org>
If a channel is being rapidly restarting and the kobj release worker is busy, there is a chance the the rpdev_release function will run after the channel struct itself has been released.
There should not be a need to decouple the channel from rpdev in the rpdev release since that should only happen from the close commands.
Signed-off-by: Chris Lew <clew@codeaurora.org> Signed-off-by: Deepak Kumar Singh <deesin@codeaurora.org> --- drivers/rpmsg/qcom_glink_native.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c index 031bc1d..efaf32d 100644 --- a/drivers/rpmsg/qcom_glink_native.c +++ b/drivers/rpmsg/qcom_glink_native.c @@ -1419,9 +1419,7 @@ static const struct rpmsg_endpoint_ops glink_endpoint_ops = { static void qcom_glink_rpdev_release(struct device *dev) { struct rpmsg_device *rpdev = to_rpmsg_device(dev); - struct glink_channel *channel = to_glink_channel(rpdev->ept); - channel->rpdev = NULL; kfree(rpdev); } -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
| |