lkml.org 
[lkml]   [2020]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 49/54] xfs: set format back to extents if xfs_bmap_extents_to_btree
    Date
    From: Eric Sandeen <sandeen@redhat.com>

    commit 2c4306f719b083d17df2963bc761777576b8ad1b upstream.

    If xfs_bmap_extents_to_btree fails in a mode where we call
    xfs_iroot_realloc(-1) to de-allocate the root, set the
    format back to extents.

    Otherwise we can assume we can dereference ifp->if_broot
    based on the XFS_DINODE_FMT_BTREE format, and crash.

    Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=199423
    Signed-off-by: Eric Sandeen <sandeen@redhat.com>
    Reviewed-by: Christoph Hellwig <hch@lst.de>
    Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
    Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
    [iwamatsu: backported to 4.4.y]
    Signed-off-by: Nobuhiro Iwamatsu (CIP) <nobuhiro1.iwamatsu@toshiba.co.jp>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    fs/xfs/libxfs/xfs_bmap.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/fs/xfs/libxfs/xfs_bmap.c
    +++ b/fs/xfs/libxfs/xfs_bmap.c
    @@ -793,6 +793,8 @@ xfs_bmap_extents_to_btree(
    *logflagsp = 0;
    if ((error = xfs_alloc_vextent(&args))) {
    xfs_iroot_realloc(ip, -1, whichfork);
    + ASSERT(ifp->if_broot == NULL);
    + XFS_IFORK_FMT_SET(ip, whichfork, XFS_DINODE_FMT_EXTENTS);
    xfs_btree_del_cursor(cur, XFS_BTREE_ERROR);
    return error;
    }

    \
     
     \ /
      Last update: 2020-07-30 10:13    [W:2.985 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site