lkml.org 
[lkml]   [2020]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v18 3/3] Input: new da7280 haptic driver
    On Wed, Jul 29, 2020 at 02:09:48PM +0000, Roy Im wrote:
    > Hello Dmitry and Uwe,
    >
    > Wednesday, July 29, 2020 3:37 PM, Dmitry Torokhov wrote:
    >
    > > On Wed, Jul 29, 2020 at 11:59:40AM +0900, Roy Im wrote:
    > > > Adds support for the Dialog DA7280 LRA/ERM Haptic Driver with multiple
    > > > mode and integrated waveform memory and wideband support.
    > > > It communicates via an I2C bus to the device.
    > >
    > > A few questions/suggestions...
    > >
    > > >
    > > > Reviewed-by: Jes Sorensen <Jes.Sorensen@gmail.com>.
    > > >
    > > > Signed-off-by: Roy Im <roy.im.opensource@diasemi.com>
    > > >
    > > > ---
    > > > v18:
    > > > - Corrected comments in Kconfig
    > > > - Updated to preferred style for multi line comments in c file.
    > > > v17:
    > > > - fixed an issue.
    > > > v16:
    > > > - Corrected some code and updated description in Kconfig.
    > > > v15:
    > > > - Removed some defines and updated some comments.
    > > > v14:
    > > > - Updated pwm related code, alignments and comments.
    > > > v13:
    > > > - Updated some conditions in pwm function and alignments.
    > > > v12: No changes.
    > > > v11:
    > > > - Updated the pwm related code, comments and typo.
    > > > v10:
    > > > - Updated the pwm related function and added some comments.
    > > > v9:
    > > > - Removed the header file and put the definitions into the c file.
    > > > - Updated the pwm code and error logs with %pE
    > >
    > > I believe the %pE is to format an escaped buffer, you probably want to %pe (lowercase) to print errors. I am also not quite sure
    > > if we want to use it in cases when we have non-pointer error, or we should stick with %d as most of the kernel does.
    >
    > Right, it should be %pe as you and Uwe said, Uwe suggested %pe to understand easier.. do you still prefer to stick with %d?

    Depends on the situation. If you already have ERR_PTR-encoded error
    there is no reason for not using %pe, but if you have integer error, or
    you have already converted pointer to integer I'd prefer we stick with
    %d.

    As I mentioned in another message maybe we should consider adding '%de'
    or similar for formatting integer errors.

    Thanks.

    --
    Dmitry

    \
     
     \ /
      Last update: 2020-07-30 07:11    [W:2.439 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site