Messages in this thread Patch in this message | | | From | Thomas Gleixner <> | Subject | Re: [patch V5 05/15] entry: Provide infrastructure for work before transitioning to guest mode | Date | Thu, 30 Jul 2020 09:19:01 +0200 |
| |
Qian Cai <cai@lca.pw> writes: > On Wed, Jul 22, 2020 at 11:59:59PM +0200, Thomas Gleixner wrote: > SR-IOV will start trigger a warning below in this commit, > > [ 765.434611] WARNING: CPU: 13 PID: 3377 at include/linux/entry-kvm.h:75 kvm_arch_vcpu_ioctl_run+0xb52/0x1320 [kvm]
Yes, I'm a moron. Fixed it locally and failed to transfer the fixup when merging it. Fix below.
> [ 768.221270] softirqs last disabled at (5093): [<ffffffffa1800ec2>] asm_call_on_stack+0x12/0x20 > [ 768.267273] ---[ end trace 8730450ad8cfee9f ]---
Can you pretty please trim your replies?
>> --- >> V5: Rename exit -> xfer (Sean)
<removed 200 lines of useless information>
Thanks,
tglx --- diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 82d4a9e88908..532597265c50 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -8682,7 +8682,7 @@ static int vcpu_run(struct kvm_vcpu *vcpu) break; } - if (xfer_to_guest_mode_work_pending()) { + if (__xfer_to_guest_mode_work_pending()) { srcu_read_unlock(&kvm->srcu, vcpu->srcu_idx); r = xfer_to_guest_mode_handle_work(vcpu); if (r)
| |