Messages in this thread |  | | Date | Fri, 3 Jul 2020 12:31:06 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH -next] perf util: Fix memory leak in __parse_regs() |
| |
On Fri, Jul 03, 2020 at 05:33:44PM +0800, Zheng Zengkai wrote: > when using perf record option '-I' or '--user-regs=' > along with argument '?' to list available register names, > memory of variable 'os' allocated by strdup() needs to be released > before __parse_regs() returns, otherwise memory leak will occur. > > Fixes: bcc84ec65ad1 ("perf record: Add ability to name registers to record") > Signed-off-by: Zheng Zengkai <zhengzengkai@huawei.com>
Acked-by: Jiri Olsa <jolsa@redhat.com>
thanks, jirka
> --- > tools/perf/util/parse-regs-options.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/parse-regs-options.c b/tools/perf/util/parse-regs-options.c > index e687497b3aac..a4a100425b3a 100644 > --- a/tools/perf/util/parse-regs-options.c > +++ b/tools/perf/util/parse-regs-options.c > @@ -54,7 +54,7 @@ __parse_regs(const struct option *opt, const char *str, int unset, bool intr) > #endif > fputc('\n', stderr); > /* just printing available regs */ > - return -1; > + goto error; > } > #ifdef HAVE_PERF_REGS_SUPPORT > for (r = sample_reg_masks; r->name; r++) { > -- > 2.20.1 >
|  |