Messages in this thread | | | Subject | RE: [PATCH v3 05/11] KVM: SVM: Modify 64 bit intercept field to two 32 bit vectors | From | Babu Moger <> | Date | Wed, 29 Jul 2020 16:31:40 -0500 |
| |
> -----Original Message----- > From: Jim Mattson <jmattson@google.com> > Sent: Wednesday, July 29, 2020 4:06 PM > To: Moger, Babu <Babu.Moger@amd.com> > Cc: Paolo Bonzini <pbonzini@redhat.com>; Vitaly Kuznetsov > <vkuznets@redhat.com>; Wanpeng Li <wanpengli@tencent.com>; Sean > Christopherson <sean.j.christopherson@intel.com>; kvm list > <kvm@vger.kernel.org>; Joerg Roedel <joro@8bytes.org>; the arch/x86 > maintainers <x86@kernel.org>; LKML <linux-kernel@vger.kernel.org>; Ingo > Molnar <mingo@redhat.com>; Borislav Petkov <bp@alien8.de>; H . Peter Anvin > <hpa@zytor.com>; Thomas Gleixner <tglx@linutronix.de> > Subject: Re: [PATCH v3 05/11] KVM: SVM: Modify 64 bit intercept field to two 32 > bit vectors > > On Tue, Jul 28, 2020 at 4:38 PM Babu Moger <babu.moger@amd.com> wrote: > > > > Convert all the intercepts to one array of 32 bit vectors in > > vmcb_control_area. This makes it easy for future intercept vector > > additions. Also update trace functions. > > > > Signed-off-by: Babu Moger <babu.moger@amd.com> > > --- > > > @@ -128,8 +129,7 @@ enum { > > > > struct __attribute__ ((__packed__)) vmcb_control_area { > > u32 intercepts[MAX_VECTORS]; > > - u64 intercept; > > - u8 reserved_1[40]; > > + u8 reserved_1[60 - (MAX_VECTORS * 4)]; > > Perhaps this could be simplified to 'u32 reserved_1[15 - MAX_VECTORS];'
Ok. Will change it. thanks
> > > u16 pause_filter_thresh; > > u16 pause_filter_count; > > u64 iopm_base_pa; > > Reviewed-by: Jim Mattson <jmattson@google.com>
| |