Messages in this thread | | | Subject | Re: [PATCH 1/7] clk: samsung: s3c64xx: Declare s3c64xx_clk_init() in shared header | From | Stephen Boyd <> | Date | Wed, 29 Jul 2020 12:42:43 -0700 |
| |
Quoting Krzysztof Kozlowski (2020-07-29 09:09:36) > diff --git a/include/linux/clk/samsung.h b/include/linux/clk/samsung.h > new file mode 100644 > index 000000000000..b6b253c46c22 > --- /dev/null > +++ b/include/linux/clk/samsung.h > @@ -0,0 +1,21 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * Copyright (c) 2020 Krzysztof Kozlowski <krzk@kernel.org> > + */ > + > +#ifndef __LINUX_CLK_SAMSUNG_H_ > +#define __LINUX_CLK_SAMSUNG_H_ > + > +#ifdef CONFIG_ARCH_S3C64XX > +void __init s3c64xx_clk_init(struct device_node *np, unsigned long xtal_f,
Don't use __init in header files. It doesn't do anything.
> + unsigned long xusbxti_f, bool s3c6400, > + void __iomem *base); > +#else > +static inline void __init s3c64xx_clk_init(struct device_node *np,
Forward declare struct device_node;
> + unsigned long xtal_f, > + unsigned long xusbxti_f, > + bool s3c6400, > + void __iomem *base) { }
Include <linux/compiler.h> (or compiler_types.h) for __iomem define please.
> +#endif /* CONFIG_ARCH_S3C64XX */ > + > +#endif /* __LINUX_CLK_SAMSUNG_H_ */
| |