Messages in this thread | | | From | Andy Shevchenko <> | Date | Wed, 29 Jul 2020 09:52:30 +0300 | Subject | Re: [PATCH 06/15] iio: sx9310: Align memory |
| |
On Wed, Jul 29, 2020 at 12:26 AM Daniel Campello <campello@google.com> wrote: > On Tue, Jul 28, 2020 at 12:11 PM Andy Shevchenko > <andy.shevchenko@gmail.com> wrote: > > On Tue, Jul 28, 2020 at 6:15 PM Daniel Campello <campello@chromium.org> wrote:
...
> > > - __be16 buffer[SX9310_NUM_CHANNELS + > > > - 4]; /* 64-bit data + 64-bit timestamp */ > > > + /* 64-bit data + 64-bit timestamp buffer */ > > > + __be16 buffer[SX9310_NUM_CHANNELS + 4] __aligned(8); > > > > If the data amount (channels) is always the same, please, use struct approach. > > Otherwise put a comment explaining dynamic data. > I'm not sure what you mean here. I have a comment above for the size > of the array.
Here [1] was a discussion about commenting on the dynamic amount of data [see the cover letter and replies to it] in the buffer and the struct approach [e.g. very first patch in the series].
[1]: https://lore.kernel.org/linux-iio/MN2PR12MB43905A2256F98BB5EFCE7DD3C4770@MN2PR12MB4390.namprd12.prod.outlook.com/T/
-- With Best Regards, Andy Shevchenko
| |