Messages in this thread | | | Date | Wed, 29 Jul 2020 18:46:35 +0200 | From | Sebastian Reichel <> | Subject | Re: [PATCH v18 2/4] dt-bindings: power: Convert battery.txt to battery.yaml |
| |
Hi Ricardo and Dan,
On Tue, Jul 28, 2020 at 03:08:12PM -0500, Ricardo Rivera-Matos wrote: > From: Dan Murphy <dmurphy@ti.com> > > Convert the battery.txt file to yaml and fix up the examples. > > Signed-off-by: Dan Murphy <dmurphy@ti.com> > Reviewed-by: Rob Herring <robh@kernel.org> > ---
I merged this doing some modifcations while applying, so that this is not postponed and risking conflicts due to added properties:
> [...] > +patternProperties: > + '^ocv-capacity-table-[0-100]$': > [...]
[0-100] is a valid regex, but counterintuitively only allows 0 and 1. For example it does not apply for ocv-capacity-table-2.
I used [0-9]+ instead, which is being used by pinctrl.
> +examples: > + - | > + power { > + #address-cells = <1>; > + #size-cells = <0>; > + > + battery: battery { > + compatible = "simple-battery"; > + over-voltage-threshold-microvolt = <4500000>; > + re-charge-voltage-microvolt = <250000>; > + voltage-min-design-microvolt = <3200000>; > + voltage-max-design-microvolt = <4200000>; > + energy-full-design-microwatt-hours = <5290000>; > + charge-full-design-microamp-hours = <1430000>; > + precharge-current-microamp = <256000>; > + precharge-upper-limit-microvolt = <2500000>; > + charge-term-current-microamp = <128000>; > + constant-charge-current-max-microamp = <900000>; > + constant-charge-voltage-max-microvolt = <4200000>; > + factory-internal-resistance-micro-ohms = <250000>; > + ocv-capacity-celsius = <(-10) 10>;
You state, that there is a table for -10 degrees and one for 10 degrees...
> + ocv-capacity-table-0 = <4185000 100>, <4113000 95>, <4066000 90>;
... and then you provide only the table for -10 degrees. I fixed this by simply using the previous example (tables for -10, 0 and 10 degrees) and 3 tables and added a comment above the tables.
-- Sebastian [unhandled content-type:application/pgp-signature] | |