lkml.org 
[lkml]   [2020]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] hv_utils: Add validation for untrusted Hyper-V values
Date
Ok at least use the ratelimit form of kernel logging.

Netdev_err_ratelimited...

-----Original Message-----
From: Andres Beltran <lkmlabelt@gmail.com>
Sent: Wednesday, July 29, 2020 9:10 AM
To: Stephen Hemminger <sthemmin@microsoft.com>
Cc: KY Srinivasan <kys@microsoft.com>; Haiyang Zhang <haiyangz@microsoft.com>; Wei Liu <wei.liu@kernel.org>; linux-hyperv@vger.kernel.org; linux-kernel@vger.kernel.org; Michael Kelley <mikelley@microsoft.com>; Andrea Parri <parri.andrea@gmail.com>; Saruhan Karademir <skarade@microsoft.com>
Subject: Re: [PATCH] hv_utils: Add validation for untrusted Hyper-V values

On Tue, Jul 28, 2020 at 5:04 PM Stephen Hemminger
<sthemmin@microsoft.com> wrote:
>
> You may want to use one of the macros that prints this once only.
> This is a "should never happen" type error, so if something goes wrong it might happens so much that journal/syslog would get overloaded.

Certainly, printing error messages once would be ideal if we were only
dealing with Linux kernel bugs. But under the assumption that Hyper-V
can send bogus values at any time, I think it would be better to print
error messages every time so that we are aware of malicious/erroneous
data sent by the host.
\
 
 \ /
  Last update: 2020-07-29 18:22    [W:0.044 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site