Messages in this thread Patch in this message | | | Date | Wed, 29 Jul 2020 18:13:18 +0200 | From | Jessica Yu <> | Subject | Re: [PATCH 2/7] modules: mark find_symbol static |
| |
+++ Christoph Hellwig [29/07/20 08:27 +0200]: >find_symbol is only used in module.c. > >Signed-off-by: Christoph Hellwig <hch@lst.de>
CCing the livepatching ML, as this may or may not impact its users.
AFAIK, the out-of-tree kpatch module had used find_symbol() in the past, I am not sure what its current status is. I suspect all of its functionality has been migrated to upstream livepatch already.
>--- > include/linux/module.h | 11 ----------- > kernel/module.c | 3 +-- > 2 files changed, 1 insertion(+), 13 deletions(-) > >diff --git a/include/linux/module.h b/include/linux/module.h >index f1fdbeef2153a8..90bdc362be3681 100644 >--- a/include/linux/module.h >+++ b/include/linux/module.h >@@ -590,17 +590,6 @@ struct symsearch { > bool unused; > }; > >-/* >- * Search for an exported symbol by name. >- * >- * Must be called with module_mutex held or preemption disabled. >- */ >-const struct kernel_symbol *find_symbol(const char *name, >- struct module **owner, >- const s32 **crc, >- bool gplok, >- bool warn); >- > /* > * Walk the exported symbol table > * >diff --git a/kernel/module.c b/kernel/module.c >index 17d64dae756c80..84da96a6d8241c 100644 >--- a/kernel/module.c >+++ b/kernel/module.c >@@ -585,7 +585,7 @@ static bool find_exported_symbol_in_section(const struct symsearch *syms, > > /* Find an exported symbol and return it, along with, (optional) crc and > * (optional) module which owns it. Needs preempt disabled or module_mutex. */ >-const struct kernel_symbol *find_symbol(const char *name, >+static const struct kernel_symbol *find_symbol(const char *name, > struct module **owner, > const s32 **crc, > bool gplok, >@@ -608,7 +608,6 @@ const struct kernel_symbol *find_symbol(const char *name, > pr_debug("Failed to find symbol %s\n", name); > return NULL; > } >-EXPORT_SYMBOL_GPL(find_symbol); > > /* > * Search for module by name: must hold module_mutex (or preempt disabled >-- >2.27.0 >
| |