Messages in this thread | | | Subject | Re: [PATCH 0/2] locking/qspinlock: Break qspinlock_types.h header loop | From | Waiman Long <> | Date | Wed, 29 Jul 2020 09:35:45 -0400 |
| |
On 7/29/20 8:28 AM, Herbert Xu wrote: > This miniseries breaks a header loop involving qspinlock_types.h. > The issue is that qspinlock_types.h includes atomic.h, which then > eventually includes kernel.h which could lead back to the original > file via spinlock_types.h. > > The first patch moves ATOMIC_INIT into linux/types.h while the second > patch actuallys breaks the loop by no longer including atomic.h > in qspinlock_types.h. > > Cheers,
This patch series looks good to me. I just wonder if we should also move ATOMIC64_INIT() to types.h for symmetry purpose. Anyway,
Acked-by: Waiman Long <longman@redhat.com>
| |