Messages in this thread | | | Date | Wed, 29 Jul 2020 08:27:56 +0100 | From | Matthew Garrett <> | Subject | Re: [PATCH] platform/x86:dell-laptop:Add battery charging thresholds and charging mode switch. |
| |
On Tue, Jul 28, 2020 at 11:54:24PM -0700, Perry Yuan wrote:
This seems extremely useful, but:
> diff --git a/Documentation/ABI/testing/sysfs-class-power b/Documentation/ABI/testing/sysfs-class-power > index bf3b48f022dc..a8adc3b0ca4b 100644 > --- a/Documentation/ABI/testing/sysfs-class-power > +++ b/Documentation/ABI/testing/sysfs-class-power > @@ -334,6 +334,29 @@ Description: > Access: Read > Valid values: Represented in microvolts > > +What: /sys/class/power_supply/<supply_name>/charge_control_charging_mode > +Date: March 2020 > +Contact: linux-pm@vger.kernel.org
The values here seem very Dell specific, but this is going into a generic sysfs path. Really stuff here should be as vendor independent as possible. If these values don't correspond to a wider industry specification it probably makes sense to make this something Dell specific.
-- Matthew Garrett | mjg59@srcf.ucam.org
| |