lkml.org 
[lkml]   [2020]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 1/3] arm64: dts: Add Mediatek SoC MT8192 and evaluation board dts and Makefile
From
Date
Hi, Seiya:

On Wed, 2020-07-29 at 09:30 +0800, Seiya Wang wrote:
> Add basic chip support for Mediatek MT8192
>
> Signed-off-by: Seiya Wang <seiya.wang@mediatek.com>
> ---
> arch/arm64/boot/dts/mediatek/Makefile | 1 +
> arch/arm64/boot/dts/mediatek/mt8192-evb.dts | 29 ++
> arch/arm64/boot/dts/mediatek/mt8192.dtsi | 671 ++++++++++++++++++++++++++++
> 3 files changed, 701 insertions(+)
> create mode 100644 arch/arm64/boot/dts/mediatek/mt8192-evb.dts
> create mode 100644 arch/arm64/boot/dts/mediatek/mt8192.dtsi
>

[snip]

> +
> + watchdog: watchdog@10007000 {
> + compatible = "mediatek,mt6589-wdt";

According to [1] and [2], compatible string for mt8192 watch dog should
be "mediatek,mt6873-wdt","mediatek,mt8192-wdt".


[1]
https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/2287090/12
[2]
https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/2131598/18

> + reg = <0 0x10007000 0 0x100>;
> + #reset-cells = <1>;
> + };
> +

[snip]

> +
> + mmsys: mmsys@14000000 {
> + compatible = "mediatek,mt8192-mmsys", "syscon";

You should define "mediatek,mt8192-mmsys" first, then you could use it
in this patch.

Regards,
CK

> + reg = <0 0x14000000 0 0x1000>;
> + #clock-cells = <1>;
> + };
> +

\
 
 \ /
  Last update: 2020-07-29 10:03    [W:2.657 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site