Messages in this thread | | | Date | Thu, 30 Jul 2020 09:11:28 +0530 | From | Viresh Kumar <> | Subject | Re: [PATCH v2 1/7] cpufreq: move invariance setter calls in cpufreq core |
| |
On 27-07-20, 15:48, Rafael J. Wysocki wrote: > On Wed, Jul 22, 2020 at 11:38 AM Ionela Voinescu > <ionela.voinescu@arm.com> wrote: > > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c > > index 036f4cc42ede..bac4101546db 100644 > > --- a/drivers/cpufreq/cpufreq.c > > +++ b/drivers/cpufreq/cpufreq.c > > @@ -2058,9 +2058,16 @@ EXPORT_SYMBOL(cpufreq_unregister_notifier); > > unsigned int cpufreq_driver_fast_switch(struct cpufreq_policy *policy, > > unsigned int target_freq) > > { > > + unsigned int freq; > > + > > target_freq = clamp_val(target_freq, policy->min, policy->max); > > + freq = cpufreq_driver->fast_switch(policy, target_freq); > > + > > + if (freq) > > + arch_set_freq_scale(policy->related_cpus, freq, > > + policy->cpuinfo.max_freq); > > Why can't arch_set_freq_scale() handle freq == 0?
Actually there is no need to. AFAIU the freq returned by fast_switch can never be 0 (yeah qcom driver does it right now and I am fixing it). And so we can drop this check altogether.
-- viresh
| |