lkml.org 
[lkml]   [2020]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v5 0/4] SFH: Add Support for AMD Sensor Fusion Hub
From
Date
Hi,

Am Dienstag, den 28.07.2020, 16:58 +0200 schrieb Marco Felsch:
> Hi,
>
> On 20-05-29 17:21, Andy Shevchenko wrote:
> > On Fri, May 29, 2020 at 4:42 PM Sandeep Singh <
> > Sandeep.Singh@amd.com> wrote:
> > > From: Sandeep Singh <sandeep.singh@amd.com>
> > >
> > > AMD SFH(Sensor Fusion Hub) is HID based driver.SFH FW
> > > is part of MP2 processor (MP2 which is an ARM® Cortex-M4
> > > core based co-processor to x86) and it runs on MP2 where
> > > in driver resides on X86.The driver functionalities are
> > > divided into three parts:-
> > >
> > > 1: amd-mp2-pcie:- This module will communicate with MP2 FW
> > > and
> > > provide that data into DRAM.
> > > 2: Client driver :- This part for driver will use dram data
> > > and
> > > convert that data into HID format based
> > > on
> > > HID reports.
> > > 3: Transport driver :- This part of driver will communicate with
> > > HID core. Communication between devices
> > > and
> > > HID core is mostly done via HID reports
> > >
> > > In terms of architecture it is much more reassembles like
> > > ISH(Intel Integrated Sensor Hub). However the major difference
> > > is all the hid reports are generated as part of kernel driver.
> > > AMD SFH driver taken reference from ISH in terms of
> > > design and functionalities at fewer location.
> > >
> > > AMD sensor fusion Hub is part of a SOC 17h family based
> > > platforms.
> > > The solution is working well on several OEM products.
> > > AMD SFH uses HID over PCIe bus.
> > >
> >
> > I can't believe this is fifth version.
> > Guys, you have to do much more work on these drivers.
>
> Is there any active development addressing Andy's comments? Else can
> we
> support you to bring these patches mainline?
>
> Regards,
> Marco

I did some major refactoring¹ on the v4 patch series and am currently
providing it for Arch Linux as a DKMS package in the AUR².
A teensy bit of my changes seems to have influenced the v5 version but
I actually did some major changes, like strictly separating the HID,
platform and PCI driver parts.
I did not submit my changes for upstream so far, since I do not want to
undermine AMD's work on this nor cause competing driver
implementations.

Sincerely,

Richard

[1] https://github.com/conqp/linux/tree/amd-sfh-hid/drivers/hid/amd-sfh-hid
[2] https://aur.archlinux.org/packages/amd-sfh-hid-dkms/

\
 
 \ /
  Last update: 2020-07-28 17:06    [W:0.046 / U:1.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site