lkml.org 
[lkml]   [2020]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [net-next v4 3/6] net: marvell: prestera: Add basic devlink support
On Tue, Jul 28, 2020 at 3:30 PM Vadym Kochan <vadym.kochan@plvision.eu> wrote:
> On Mon, Jul 27, 2020 at 04:07:07PM +0300, Andy Shevchenko wrote:
> > On Mon, Jul 27, 2020 at 3:23 PM Vadym Kochan <vadym.kochan@plvision.eu> wrote:

...

> > > + err = devlink_register(dl, sw->dev->dev);
> > > + if (err) {
> > > + dev_warn(sw->dev->dev, "devlink_register failed: %d\n", err);
> > > + return err;
> > > + }
> > > +
> > > + return 0;
> >
> > if (err)
> > dev_warn(...);
> >
> > return err;
> Would not it better to have 'return 0' at the end to visually indicate
> the success point ?

Up to you. Actually just noticed that you are using dev_warn() for
error. It should be dev_err().

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2020-07-28 15:26    [W:0.054 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site