lkml.org 
[lkml]   [2020]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH bpf-next v2 35/35] perf: don't touch RLIMIT_MEMLOCK
Em Mon, Jul 27, 2020 at 11:09:43PM -0700, Andrii Nakryiko escreveu:
> On Mon, Jul 27, 2020 at 12:21 PM Roman Gushchin <guro@fb.com> wrote:
> >
> > Since bpf stopped using memlock rlimit to limit the memory usage,
> > there is no more reason for perf to alter its own limit.
> >
> > Signed-off-by: Roman Gushchin <guro@fb.com>
> > ---
>
> Cc'd Armaldo, but I'm guessing it's a similar situation that latest
> perf might be running on older kernel and should keep working.

Yes, please leave it as is, the latest perf should continue working with
older kernels, so if there is a way to figure out if the kernel running
is one where BPF doesn't use memlock rlimit for that purpose, then in
those cases we shouldn't use it.

- Arnaldo

> > tools/perf/builtin-trace.c | 10 ----------
> > tools/perf/tests/builtin-test.c | 6 ------
> > tools/perf/util/Build | 1 -
> > tools/perf/util/rlimit.c | 29 -----------------------------
> > tools/perf/util/rlimit.h | 6 ------
> > 5 files changed, 52 deletions(-)
> > delete mode 100644 tools/perf/util/rlimit.c
> > delete mode 100644 tools/perf/util/rlimit.h
> >
>
> [...]

--

- Arnaldo

\
 
 \ /
  Last update: 2020-07-28 14:14    [W:0.272 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site