Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH 0/3] Convert nsproxy, groups, and creds to refcount_t | Date | Tue, 28 Jul 2020 12:01:51 +0100 |
| |
Kees Cook <keescook@chromium.org> wrote:
> > I've been gradually undoing some of the conversions as there's no equivalent > > of atomic_add_return() and atomic_dec_return() that allow me to log the > > altered refcount through a tracepoint. > > Please do not _undo_ the changes; just add the API you need.
And _please_ do not convert atomic_inc/dec_return() into refcount_read() + refcount_xxx(). They are _not_ equivalent.
David
| |