| From | Dave Stevenson <> | Date | Tue, 28 Jul 2020 10:50:42 +0100 | Subject | Re: [PATCH v4 11/78] drm/vc4: crtc: Use local chan variable |
| |
Hi Maxime
On Wed, 8 Jul 2020 at 18:42, Maxime Ripard <maxime@cerno.tech> wrote: > > The vc4_crtc_handle_page_flip already has a local variable holding the > value of vc4_crtc->channel, so let's use it instead. > > Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
> --- > drivers/gpu/drm/vc4/vc4_crtc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c > index d3126fe04d9a..cdeaa0cd981f 100644 > --- a/drivers/gpu/drm/vc4/vc4_crtc.c > +++ b/drivers/gpu/drm/vc4/vc4_crtc.c > @@ -533,7 +533,7 @@ static void vc4_crtc_handle_page_flip(struct vc4_crtc *vc4_crtc) > * the CRTC and encoder already reconfigured, leading to > * underruns. This can be seen when reconfiguring the CRTC. > */ > - vc4_hvs_unmask_underrun(dev, vc4_crtc->channel); > + vc4_hvs_unmask_underrun(dev, chan); > } > spin_unlock_irqrestore(&dev->event_lock, flags); > } > -- > git-series 0.9.1
|