Messages in this thread | | | Subject | Re: [PATCH 2/2] media: bt8xx: avoid a useless memset | From | Christophe JAILLET <> | Date | Tue, 28 Jul 2020 10:01:20 +0200 |
| |
Le 27/07/2020 à 18:09, Joe Perches a écrit : > On Mon, 2020-07-27 at 15:51 +0200, Christophe JAILLET wrote: >> Avoid a memset after a call to 'dma_alloc_coherent()'. >> This is useless since >> commit 518a2f1925c3 ("dma-mapping: zero memory returned from dma_alloc_*") > [] >> diff --git a/drivers/media/pci/bt8xx/btcx-risc.c b/drivers/media/pci/bt8xx/btcx-risc.c > [] >> @@ -73,7 +73,6 @@ int btcx_riscmem_alloc(struct pci_dev *pci, >> dprintk("btcx: riscmem alloc [%d] dma=%lx cpu=%p size=%d\n", >> memcnt, (unsigned long)dma, cpu, size); >> } >> - memset(risc->cpu,0,risc->size); >> return 0; >> } > > Likely NAK. > > This is not useless as risc->cpu may be reused > and the alloc may not have been done. > > > Agreed. This 2/2 patch should be NAK'ed.
I've been a bit too fast on this one. Thanks for the review Joe.
CJ
| |