lkml.org 
[lkml]   [2020]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/2] media: bt8xx: avoid a useless memset
From
Date
Le 27/07/2020 à 18:09, Joe Perches a écrit :
> On Mon, 2020-07-27 at 15:51 +0200, Christophe JAILLET wrote:
>> Avoid a memset after a call to 'dma_alloc_coherent()'.
>> This is useless since
>> commit 518a2f1925c3 ("dma-mapping: zero memory returned from dma_alloc_*")
> []
>> diff --git a/drivers/media/pci/bt8xx/btcx-risc.c b/drivers/media/pci/bt8xx/btcx-risc.c
> []
>> @@ -73,7 +73,6 @@ int btcx_riscmem_alloc(struct pci_dev *pci,
>> dprintk("btcx: riscmem alloc [%d] dma=%lx cpu=%p size=%d\n",
>> memcnt, (unsigned long)dma, cpu, size);
>> }
>> - memset(risc->cpu,0,risc->size);
>> return 0;
>> }
>
> Likely NAK.
>
> This is not useless as risc->cpu may be reused
> and the alloc may not have been done.
>
>
>
Agreed.
This 2/2 patch should be NAK'ed.

I've been a bit too fast on this one.
Thanks for the review Joe.

CJ

\
 
 \ /
  Last update: 2020-07-28 10:02    [W:0.080 / U:1.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site