lkml.org 
[lkml]   [2020]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] remoteproc: qcom_q6v5_mss: Remove redundant running state
On Tue 02 Jun 09:32 PDT 2020, Sibi Sankar wrote:

> Remove the redundant running state, as an equivalent is maintained in
> the common q6v5 resource handling helpers.
>
> Signed-off-by: Sibi Sankar <sibis@codeaurora.org>

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

> ---
> drivers/remoteproc/qcom_q6v5_mss.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom_q6v5_mss.c
> index feb70283b6a21..702352cd66188 100644
> --- a/drivers/remoteproc/qcom_q6v5_mss.c
> +++ b/drivers/remoteproc/qcom_q6v5_mss.c
> @@ -178,8 +178,6 @@ struct q6v5 {
> int active_reg_count;
> int proxy_reg_count;
>
> - bool running;
> -
> bool dump_mba_loaded;
> unsigned long dump_segment_mask;
> unsigned long dump_complete_mask;
> @@ -1275,7 +1273,6 @@ static int q6v5_start(struct rproc *rproc)
>
> /* Reset Dump Segment Mask */
> qproc->dump_segment_mask = 0;
> - qproc->running = true;
>
> return 0;
>
> @@ -1290,8 +1287,6 @@ static int q6v5_stop(struct rproc *rproc)
> struct q6v5 *qproc = (struct q6v5 *)rproc->priv;
> int ret;
>
> - qproc->running = false;
> -
> ret = qcom_q6v5_request_stop(&qproc->q6v5);
> if (ret == -ETIMEDOUT)
> dev_err(qproc->dev, "timed out on wait\n");
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>

\
 
 \ /
  Last update: 2020-07-28 08:24    [W:0.084 / U:0.396 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site