Messages in this thread | | | Date | Tue, 28 Jul 2020 21:56:40 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH v3 15/19] IMA: Add support for file reads without contents |
| |
On Tue, Jul 28, 2020 at 12:44:50PM -0700, Kees Cook wrote: > On Mon, Jul 27, 2020 at 09:23:34AM -0400, Mimi Zohar wrote: > > On Fri, 2020-07-24 at 14:36 -0700, Kees Cook wrote: > > > From: Scott Branden <scott.branden@broadcom.com> > > > > > > When the kernel_read_file LSM hook is called with contents=false, IMA > > > can appraise the file directly, without requiring a filled buffer. When > > > such a buffer is available, though, IMA can continue to use it instead > > > of forcing a double read here. > > > > > > Signed-off-by: Scott Branden <scott.branden@broadcom.com> > > > Link: https://lore.kernel.org/lkml/20200706232309.12010-10-scott.branden@broadcom.com/ > > > Signed-off-by: Kees Cook <keescook@chromium.org> > > > > After adjusting the comment below. > > > > Reviewed-by: Mimi Zohar <zohar@linux.ibm.com> > > Sure! > > Greg, shall I send a v4 with added Reviews and the comment change or is > that minor enough that you're able to do it?
v4 is needed, as this series is a mess of reviewes and you will have to redo at least one patch and drop some others, right?
thanks,
greg k-h
| |