lkml.org 
[lkml]   [2020]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.7 064/179] arm64: dts: clearfog-gt-8k: fix switch link configuration
    Date
    From: Russell King <rmk+kernel@armlinux.org.uk>

    [ Upstream commit 7c6719a1aaca51ffd7cdf3905e70aa8313f6ef26 ]

    The commit below caused a regression for clearfog-gt-8k, where the link
    between the switch and the host does not come up.

    Investigation revealed two issues:
    - MV88E6xxx DSA no longer allows an in-band link to come up as the link
    is programmed to be forced down. Commit "net: dsa: mv88e6xxx: fix
    in-band AN link establishment" addresses this.

    - The dts configured dissimilar link modes at each end of the host to
    switch link; the host was configured using a fixed link (so has no
    in-band status) and the switch was configured to expect in-band
    status.

    With both issues fixed, the regression is resolved.

    Fixes: 34b5e6a33c1a ("net: dsa: mv88e6xxx: Configure MAC when using fixed link")
    Reported-by: Martin Rowe <martin.p.rowe@gmail.com>
    Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
    Reviewed-by: Andrew Lunn <andrew@lunn.ch>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts | 5 +----
    1 file changed, 1 insertion(+), 4 deletions(-)

    diff --git a/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts b/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
    index b90d78a5724b2..e32a491e909f1 100644
    --- a/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
    +++ b/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
    @@ -454,10 +454,7 @@
    status = "okay";
    phy-mode = "2500base-x";
    phys = <&cp1_comphy5 2>;
    - fixed-link {
    - speed = <2500>;
    - full-duplex;
    - };
    + managed = "in-band-status";
    };

    &cp1_spi1 {
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-07-27 16:21    [W:4.394 / U:0.444 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site