lkml.org 
[lkml]   [2020]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 093/138] hwmon: (nct6775) Accept PECI Calibration as temperature source for NCT6798D
    Date
    From: Guenter Roeck <linux@roeck-us.net>

    [ Upstream commit 8a03746c8baf82e1616f05a1a716d34378dcf780 ]

    Stefan Dietrich reports invalid temperature source messages on Asus Formula
    XII Z490.

    nct6775 nct6775.656: Invalid temperature source 28 at index 0,
    source register 0x100, temp register 0x73

    Debugging suggests that temperature source 28 reports the CPU temperature.
    Let's assume that temperature sources 28 and 29 reflect "PECI Agent {0,1}
    Calibration", similar to other chips of the series.

    Reported-by: Stefan Dietrich <roots@gmx.de>
    Cc: Stefan Dietrich <roots@gmx.de>
    Signed-off-by: Guenter Roeck <linux@roeck-us.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/hwmon/nct6775.c | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    diff --git a/drivers/hwmon/nct6775.c b/drivers/hwmon/nct6775.c
    index 7efa6bfef0609..ba9b96973e808 100644
    --- a/drivers/hwmon/nct6775.c
    +++ b/drivers/hwmon/nct6775.c
    @@ -786,13 +786,13 @@ static const char *const nct6798_temp_label[] = {
    "Agent1 Dimm1",
    "BYTE_TEMP0",
    "BYTE_TEMP1",
    - "",
    - "",
    + "PECI Agent 0 Calibration", /* undocumented */
    + "PECI Agent 1 Calibration", /* undocumented */
    "",
    "Virtual_TEMP"
    };

    -#define NCT6798_TEMP_MASK 0x8fff0ffe
    +#define NCT6798_TEMP_MASK 0xbfff0ffe
    #define NCT6798_VIRT_TEMP_MASK 0x80000c00

    /* NCT6102D/NCT6106D specific data */
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-07-27 16:17    [W:2.881 / U:0.372 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site