lkml.org 
[lkml]   [2020]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 047/138] drm: sun4i: hdmi: Fix inverted HPD result
    Date
    From: Chen-Yu Tsai <wens@csie.org>

    [ Upstream commit baa1841eb797eadce6c907bdaed7cd6f01815404 ]

    When the extra HPD polling in sun4i_hdmi was removed, the result of
    HPD was accidentally inverted.

    Fix this by inverting the check.

    Fixes: bda8eaa6dee7 ("drm: sun4i: hdmi: Remove extra HPD polling")
    Signed-off-by: Chen-Yu Tsai <wens@csie.org>
    Tested-by: Mans Rullgard <mans@mansr.com>
    Signed-off-by: Maxime Ripard <maxime@cerno.tech>
    Link: https://patchwork.freedesktop.org/patch/msgid/20200711011030.21997-1-wens@kernel.org
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c b/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c
    index 63b4de81686ac..4acdfa6087751 100644
    --- a/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c
    +++ b/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c
    @@ -263,7 +263,7 @@ sun4i_hdmi_connector_detect(struct drm_connector *connector, bool force)
    unsigned long reg;

    reg = readl(hdmi->base + SUN4I_HDMI_HPD_REG);
    - if (reg & SUN4I_HDMI_HPD_HIGH) {
    + if (!(reg & SUN4I_HDMI_HPD_HIGH)) {
    cec_phys_addr_invalidate(hdmi->cec_adap);
    return connector_status_disconnected;
    }
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-07-27 16:15    [W:7.155 / U:0.136 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site