Messages in this thread | | | Date | Mon, 27 Jul 2020 15:39:49 +0200 | From | Christian Brauner <> | Subject | Re: [PATCH] userns: Fix a kernel coding style issue |
| |
On Mon, Jul 27, 2020 at 05:18:23PM +0545, Yadav Lamichhane wrote: > fix a brace around if-else statement and for loop. > > Signed-off-by: Yadav Lamichhane <tuxomega1@gmail.com> > --- > kernel/user_namespace.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/kernel/user_namespace.c b/kernel/user_namespace.c > index 87804e0371fe..7703753cac97 100644 > --- a/kernel/user_namespace.c > +++ b/kernel/user_namespace.c > @@ -118,9 +118,8 @@ int create_user_ns(struct cred *new) > ns->owner = owner; > ns->group = group; > INIT_WORK(&ns->work, free_user_ns); > - for (i = 0; i < UCOUNT_COUNTS; i++) { > + for (i = 0; i < UCOUNT_COUNTS; i++) > ns->ucount_max[i] = INT_MAX; > - } > ns->ucounts = ucounts; > > /* Inherit USERNS_SETGROUPS_ALLOWED from our parent */ > @@ -1156,12 +1155,10 @@ ssize_t proc_setgroups_write(struct file *file, const char __user *buf, > if (strncmp(pos, "allow", 5) == 0) { > pos += 5; > setgroups_allowed = true; > - } > - else if (strncmp(pos, "deny", 4) == 0) { > + } else if (strncmp(pos, "deny", 4) == 0) { > pos += 4; > setgroups_allowed = false; > - } > - else > + } else > goto out;
Kernel coding style would mandate that the else be enclosed in {} as well.
Christian
| |