Messages in this thread | | | Date | Mon, 27 Jul 2020 14:02:40 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH v4 1/3] arm64: dts: Add a device tree for the Librem 5 phone |
| |
Hi!
> + pwmleds { > + compatible = "pwm-leds"; > + > + blue { > + label = "blue:status"; > + max-brightness = <248>; > + pwms = <&pwm2 0 50000>; > + }; > + > + green { > + label = "green:status"; > + max-brightness = <248>; > + pwms = <&pwm4 0 50000>; > + }; > + > + red { > + label = "red:status"; > + max-brightness = <248>; > + pwms = <&pwm3 0 50000>; > + }; > + };
Can we postpone this?
1) green:status is not really name used anywhere else
2) this should really use multicolor framework, as it is single LED, not three of them.
Fixing that in future will be hard :-(. Pavel
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [unhandled content-type:application/pgp-signature] | |