Messages in this thread | | | Date | Mon, 27 Jul 2020 14:46:49 -0700 | From | Guru Das Srinagesh <> | Subject | Re: [PATCH RCC 1/6] pwm: Add different PWM output types support |
| |
On Fri, Jul 24, 2020 at 11:36:51PM +0200, Martin Botka wrote: > From: Fenglin Wu <fenglinw@codeaurora.org> > > Normally, PWM channel has fixed output until software request to change > its settings. There are some PWM devices which their outputs could be > changed autonomously according to a predefined pattern programmed in > hardware. Add pwm_output_type enum type to identify these two different > PWM types and add relevant helper functions to set and get PWM output > types and pattern. > > Signed-off-by: Fenglin Wu <fenglinw@codeaurora.org> > [konradybcio@gmail.com: Fast-forward from kernel 4.14 to 5.8] > Signed-off-by: Konrad Dybcio <konradybcio@gmail.com> > Signed-off-by: Martin Botka <martin.botka1@gmail.com>
Hello,
Re-sending my reply as somehow the cc-fields got dropped when I posted earlier.
This was the feedback received from the maintainers when I posted this patch last year [1]. Accordingly, we updated the patch to drop "output_pattern" altogether and made "output_type" read-only [2] - haven't attempted upstreaming this version yet.
[1]: https://lore.kernel.org/lkml/20190916140146.GC7488@ulmo/ [2]: https://android-review.googlesource.com/c/kernel/common/+/1170135
Thank you.
Guru Das.
| |