lkml.org 
[lkml]   [2020]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] integrity: remove redundant initialization of variable ret
From
Date
On Tue, 2020-07-28 at 04:05 +1000, James Morris wrote:
> On Wed, 1 Jul 2020, Colin King wrote:
>
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > The variable ret is being initialized with a value that is never read
> > and it is being updated later with a new value. The initialization is
> > redundant and can be removed.
> >
> > Addresses-Coverity: ("Unused value")
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > ---
> > security/integrity/digsig_asymmetric.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/security/integrity/digsig_asymmetric.c b/security/integrity/digsig_asymmetric.c
> > index 4e0d6778277e..cfa4127d0518 100644
> > --- a/security/integrity/digsig_asymmetric.c
> > +++ b/security/integrity/digsig_asymmetric.c
> > @@ -79,7 +79,7 @@ int asymmetric_verify(struct key *keyring, const char *sig,
> > struct public_key_signature pks;
> > struct signature_v2_hdr *hdr = (struct signature_v2_hdr *)sig;
> > struct key *key;
> > - int ret = -ENOMEM;
> > + int ret;
>
> Assuming Mimi will grab this.
>
>
> Acked-by: James Morris <jamorris@linux.microsoft.com>

Yes, thank you for the reminder.

Mimi

\
 
 \ /
  Last update: 2020-07-27 22:58    [W:0.035 / U:0.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site