Messages in this thread | | | Date | Mon, 27 Jul 2020 21:56:38 +0200 | From | Greg KH <> | Subject | Re: [PATCH v3] usb: dwc2: Add missing cleanups when usb_add_gadget_udc() fails |
| |
On Mon, Jul 27, 2020 at 07:38:01PM +0200, Martin Blumenstingl wrote: > Call dwc2_debugfs_exit() and dwc2_hcd_remove() (if the HCD was enabled > earlier) when usb_add_gadget_udc() has failed. This ensures that the > debugfs entries created by dwc2_debugfs_init() as well as the HCD are > cleaned up in the error path. > > Fixes: 207324a321a866 ("usb: dwc2: Postponed gadget registration to the udc class driver") > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > --- > Changes since v2 at [1]: > - add #if around the new label and it's code to prevent the following > warning found by the Kernel test robot: > unused label 'error_debugfs' [-Wunused-label] > > Changes since v1 at [0] > - also cleanup the HCD as suggested by Minas (thank you!) > - updated the subject accordingly > > > [0] https://patchwork.kernel.org/patch/11631381/ > [1] https://patchwork.kernel.org/patch/11642957/
<formletter>
This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.
</formletter>
| |